Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated TileMap with TileMapLayer #18

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

wjt
Copy link
Member

@wjt wjt commented Dec 5, 2024

Since commit ef98998, this project has required Godot 4.3. In Godot 4.3, TileMap is deprecated in favour of TileMapLayer, and a warning to that effect is shown in the scene tree.

The warning, and the documentation, explains how to migrate to TileMapLayer. It was a little more involved than clicking that button because we have a separate .tscn file for the tilemap, instance it in the main scene, and draw the actual map in the instance in the main. Essentially I used the automated process, then moved the node & properties to the right places by hand.

https://docs.godotengine.org/en/stable/classes/class_tilemap.html

Since commit ef98998, this project has required Godot 4.3. In Godot
4.3, TileMap is deprecated in favour of TileMapLayer, and a warning to
that effect is shown in the scene tree.

The warning, and the documentation, explains how to migrate to
TileMapLayer. It was a little more involved than clicking that button
because we have a separate .tscn file for the tilemap, instance it in
the main scene, and draw the actual map in the instance in the main.
Essentially I used the automated process, then moved the node &
properties to the right places by hand.

https://docs.godotengine.org/en/stable/classes/class_tilemap.html
@wjt wjt requested a review from manuq December 5, 2024 17:48
Copy link
Contributor

@manuq manuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to do the Tile Set modding in this branch, no regression found.

@manuq manuq merged commit bd989ac into main Dec 5, 2024
1 check passed
@manuq manuq deleted the push-mpltnqsslttp branch December 5, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants