You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the subgraph's definition of checkPccBurned is the inverse logic of that of ensjs — this tells me that the method is named incorrectly, though the indexing logic may be correct, still. it seems that the logic as written reads as "update expiry if PCC is SET", since the subgraph's checkPccBurned util return true if the PCC flag is enabled on the fuses.
if the indexing logic is correct i'd propose a rename of this function to isPccSet or refactoring to use ensjs's utility and invert its response to achieve the same indexing logic. if the indexing logic is incorrect because of this, i'd propose refactoring to use ensjs's utility and not inverting its response.
The text was updated successfully, but these errors were encountered:
the subgraph's definition of
checkPccBurned
is the inverse logic of that of ensjs — this tells me that the method is named incorrectly, though the indexing logic may be correct, still. it seems that the logic as written reads as "update expiry if PCC is SET", since the subgraph'scheckPccBurned
util return true if the PCC flag is enabled on the fuses.for context, the subgraph's definition is this:
https://github.com/ensdomains/ens-subgraph/blob/master/src/nameWrapper.ts#L63C1-L65C2
and ensjs's is this
https://github.com/ensdomains/ensjs/blob/main/packages/ensjs/src/utils/fuses.ts#L384-L385
if the indexing logic is correct i'd propose a rename of this function to
isPccSet
or refactoring to use ensjs's utility and invert its response to achieve the same indexing logic. if the indexing logic is incorrect because of this, i'd propose refactoring to use ensjs's utility and not inverting its response.The text was updated successfully, but these errors were encountered: