Skip to content
This repository has been archived by the owner on Jul 5, 2018. It is now read-only.

Manually changing planets forces a re-check for CheckSwitchBetterPlanet() #83

Open
ensingm2 opened this issue Jul 2, 2018 · 2 comments
Labels
bug Something isn't working low-priority

Comments

@ensingm2
Copy link
Owner

ensingm2 commented Jul 2, 2018

This means you effectively cannot switch planets manually, as you'll immediately auto-switch back.

This would normally be low priority, as I don't think many people use the override often, but it does break our testing of planet-switching, specifically for issue #81

@Harest
Copy link
Collaborator

Harest commented Jul 2, 2018

I think it only calls SwitchNextZone() cf. the callback for INJECT_switch_planet ? So the best way to avoid the automatic CheckSwitchBetterPlanet() being done at each INJECT_start_round() would be to set auto-switch for planets to false when you manually exit a planet to join another. Maybe adding a warning too somehow.

A potential issue too is for players that want to target a specific zone manually. Due to the zone 0 of planet 38 and the undefined error i changed the call at the end of a round in loop_rounds if from INJECT_start_round to SwitchNextZone(). It also allows a check for a boss on the current planet as it'd not do so otherwise (with auto-switch planet disabled). Before you'd just stay in the same zone forever until the zone was captured. Especially if it was max diff (3).

@ensingm2
Copy link
Owner Author

ensingm2 commented Jul 2, 2018

I wouldn't worry too much about this, unless it becomes a big issue when testing other bugs. It's likely more hassle than it's worth to try to figure out maintaining auto-swap/override states(manual swap sets a flag until zone ends, then swap back, I guess?). Would likely run into other issues with the error handling, etc. I'm good leaving this issue open/documented but unfixed, unless there's some magic easy fix.

@ensingm2 ensingm2 added bug Something isn't working low-priority labels Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working low-priority
Projects
None yet
Development

No branches or pull requests

2 participants