Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove \ from IR.Type.Set but support & #6165

Closed
JaroslavTulach opened this issue Apr 1, 2023 · 5 comments · Fixed by #7769
Closed

Remove \ from IR.Type.Set but support & #6165

JaroslavTulach opened this issue Apr 1, 2023 · 5 comments · Fixed by #7769
Assignees

Comments

@JaroslavTulach
Copy link
Member

There are some SugaredTypeFunctionsTest that deal with support for sets(!?) and produce IR.Type.Set. Some of the operations seem to be working (like T & P or T | P) but some of them aren't. Particularly the T \ P syntax seems to contradict with the "new syntax for lambdas".

Please take a look at SugaredTypeFunctionsTest three failing tests:

  • should resolve context ascription
  • should resolve equality
  • should resolve subtraction

and decide whether such tests are supposed to be fixed or deleted. Thanks for your help.

@wdanilo
Copy link
Member

wdanilo commented Apr 4, 2023

You are right. The syntax T \ P is not working anymore, as it's needed for lambdas. However, I am not sure we will support full boolean algebra on contexts. In particular, I'm not sure if we can support the \ operator in a general sense. Maybe we could, but until we are sure about it and it is correctly designed, I'd propose to just remove the \ boolean operator and use this syntax for lambdas only.

@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Apr 6, 2023

just remove the \ boolean operator and use this syntax for lambdas only.

OK. Let's remove \ operator support. Shall we keep all the others &, |, etc. or attempt to remove this whole IR.Type.Set support?

@wdanilo
Copy link
Member

wdanilo commented Apr 10, 2023

Yes, we should keep them. String | Nothing and similar types are super useful and are foundation for many things we are designing with James.

@JaroslavTulach JaroslavTulach changed the title Evaluate support of IR.Type.Set in the new parser Remove support for \ in IR.Type.Set in the new parser Apr 18, 2023
@JaroslavTulach JaroslavTulach added this to the Beta Release milestone Apr 18, 2023
@JaroslavTulach JaroslavTulach changed the title Remove support for \ in IR.Type.Set in the new parser Remove support for \ in IR.Type.Set from the parser Apr 18, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Apr 18, 2023
@jdunkerley jdunkerley removed this from the Beta Release milestone Jul 11, 2023
@JaroslavTulach JaroslavTulach changed the title Remove support for \ in IR.Type.Set from the parser Remove \ from IR.Type.Set but support & Sep 7, 2023
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to ⚙️ Design in Issues Board Sep 7, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 9, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-09-08):

Progress: - PR: #7769

Next Day: Bugfixing

@JaroslavTulach JaroslavTulach moved this from ⚙️ Design to 👁️ Code review in Issues Board Sep 11, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 11, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 12, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-09-11):

Progress: - removing \ supporting & integrated: #7769

Next Day: Bugfixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants