More IR mini passes

[Akirathan]

Closes #11326

Pull Request Description

Mega passes converted to minipasses in Passes.globalTypingPasses group:

enso/engine/runtime-compiler/src/main/scala/org/enso/compiler/Passes.scala

Lines 41 to 63 in 4e6837f

	val globalTypingPasses = new PassGroup(
	List(
	MethodDefinitions.INSTANCE,
	SectionsToBinOp.INSTANCE,
	OperatorToFunction,
	LambdaShorthandToLambda,
	ImportSymbolAnalysis.INSTANCE,
	AmbiguousImportsAnalysis.INSTANCE
	) ++ (if (config.privateCheckEnabled) {
	List(
	PrivateModuleAnalysis.INSTANCE,
	PrivateConstructorAnalysis.INSTANCE
	)
	} else List())
	++ List(
	ShadowedPatternFields,
	UnreachableMatchBranches,
	NestedPatternMatch,
	IgnoredBindings,
	TypeFunctions,
	TypeSignatures
	)
	)

Are:

• MethodDefinitions
• ImportSymbolAnalysis
• AmbiguousImportsAnalysis
• PrivateModuleAnalysis
• PrivateConstructorAnalysis

All of these mini passes are ordered after each other. So now, in Passes.globalTypingPasses group, there are 8 consecutive minipasses.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  TypeScript,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• Unit tests have been written where possible.
• Benchmarks are solid:
  • engine benchmarks run #1
    • In run 1, MethodDefinitions is still mega pass. Scheduling another one:
  • engine benchmarks run #2

[JaroslavTulach]

I would rather not increase the amount of projects that depend on Scala.

[JaroslavTulach]

I guess the above .map body and the for loop body could easily be merged together into one big for loop.

[JaroslavTulach]

Unrelated to this PR.

What would it take to register only static methods in each type? What's an invocation of (x:Integer).to_text anyway? It should be convertible to Integer.to_text x - e.g. an instance invocation just resolves the right method based on the type of the instances, but then it invokes the static Function.

Benefit:

• reduce the amount of Function instances in the system by half

Prior art:

• Graal compiler sees all JVM methods as static (instances methods of a class being static and having this as first argument)
• the compiler only has special InvokeNode that deals with finding the right method to invoke when virtual dispatch is necessary

[Akirathan]

Created an issue #11686 from your comment.

[JaroslavTulach]

Thanks for moving the shared Scala utilities to scala-libs-wrapper and keeping engine-common as lightweight as it was. That was the biggest architectural flaw.

From a code point of view, I believe there is a mistake in ChainedMiniPass - it can never unregister completely from the traversal.

Otherwise it all looks good and thanks for increasing the test coverage.