Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayDataSource __getstate__ doesn't call super #248

Closed
corranwebster opened this issue Dec 18, 2014 · 3 comments
Closed

ArrayDataSource __getstate__ doesn't call super #248

corranwebster opened this issue Dec 18, 2014 · 3 comments
Labels
type: bug

Comments

@corranwebster
Copy link
Contributor

It probably should, given that AbstractDataSource.__getstate__ does things.
@rahulporuri
Copy link
Contributor

note that #250 supercedes this issue and this issue can be closed if the serialization code is removed.

@corranwebster
Copy link
Contributor Author

No, #250 does not supercede - __getstate__ is standard Python stuff (https://docs.python.org/3/library/pickle.html#object.__getstate__) and there's additional Traits support for __getstate__ IIRC.

@aaronayres35
Copy link
Contributor

this was fixed in #633

@aaronayres35 aaronayres35 mentioned this issue May 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@corranwebster @rahulporuri @aaronayres35