Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent prime number generation #25

Open
fjarri opened this issue May 13, 2023 · 3 comments
Open

Consistent prime number generation #25

fjarri opened this issue May 13, 2023 · 3 comments
Labels
enhancement New feature or request tests Test suite

Comments

@fjarri
Copy link
Member

fjarri commented May 13, 2023

For some applications where a prime is generated as an output of some hash, it is important to make sure that the same prime number is produced given the same RNG state. We need to add a test with some pre-generated primes with given RNG states, and make sure that when that test detects a change, it is either reverted, or considered a breaking change in the crate.

@fjarri fjarri added enhancement New feature or request tests Test suite labels May 13, 2023
@kayabaNerve
Copy link

Why isn't this outsourced to calling generate_prime_with_rng where the passed in RNG is seeded?

@fjarri
Copy link
Member Author

fjarri commented Dec 27, 2023

It's not about being consistent within the same version of the library (which is the case now), but about being consistent within the same major version.

@kayabaNerve
Copy link

Ah, thanks for the clarification. Agreed on the value of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Test suite
Projects
None yet
Development

No branches or pull requests

2 participants