Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further coverage of UintLike #37

Closed
wants to merge 39 commits into from
Closed

Further coverage of UintLike #37

wants to merge 39 commits into from

Commits on Dec 13, 2023

  1. Bump crypto-bigint and start transitioning to traits

    @fjarri @xuganyu96
    fjarri authored and xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    fed515e View commit details
    Browse the repository at this point in the history

  2. Convert sieve

    @fjarri @xuganyu96
    fjarri authored and xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e5ee6be View commit details
    Browse the repository at this point in the history

  3. Convert miller_rabin

    @fjarri @xuganyu96
    fjarri authored and xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    d5fff44 View commit details
    Browse the repository at this point in the history

  4. Convert presets

    @fjarri @xuganyu96
    fjarri authored and xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0632514 View commit details
    Browse the repository at this point in the history

  5. Convert traits

    @fjarri @xuganyu96
    fjarri authored and xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8041216 View commit details
    Browse the repository at this point in the history

  6. Updates for the crypto-bigint@bcb41ff42b0eae91440d60d67c9173e8f2280de5

    @fjarri @xuganyu96
    fjarri authored and xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    bf44bb5 View commit details
    Browse the repository at this point in the history

  7. Bit count uses u32 instead of usize

    @xuganyu96
    xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    6d5e81a View commit details
    Browse the repository at this point in the history

  8. Removed ambiguous candidates between UintLike and Integer

    @xuganyu96
    xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1609d00 View commit details
    Browse the repository at this point in the history

  9. Parameterize benchmarks with T: UintLike

    @xuganyu96
    xuganyu96 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    efeab19 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Patch latest version of crypto-bigint

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7c95144 View commit details
    Browse the repository at this point in the history

  2. Implemented SMallMod for BoxedUint

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1598586 View commit details
    Browse the repository at this point in the history

  3. shift now returns self and ConstChoice

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    0a3686a View commit details
    Browse the repository at this point in the history

  4. Reciprocal::new is now const fn

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    d90cb3d View commit details
    Browse the repository at this point in the history

  5. JacobiSymbol is public under hazmat::JacobiSymbol

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    cd676ba View commit details
    Browse the repository at this point in the history

  6. Implemented Jacobi with UintLike

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    e62362c View commit details
    Browse the repository at this point in the history

  7. Implemented gcd with UintLike

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    cabe201 View commit details
    Browse the repository at this point in the history

  8. But ct_div_rem_limb_with_reciprocal is actually not const fn

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    0fa0582 View commit details
    Browse the repository at this point in the history

  9. Flawed implementation of Random

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ba9d3c5 View commit details
    Browse the repository at this point in the history

  10. passed more prime generation tests

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    6985061 View commit details
    Browse the repository at this point in the history

  11. passed more prime generation tests

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    5471920 View commit details
    Browse the repository at this point in the history

  12. All tests pass now

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    2449f8f View commit details
    Browse the repository at this point in the history

  13. Typo

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    6b73400 View commit details
    Browse the repository at this point in the history

  14. Updated documentation for bits_precision

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    72c4eee View commit details
    Browse the repository at this point in the history

  15. listed things to implement for BoxedUint and BoxedResidue

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    dcfedd1 View commit details
    Browse the repository at this point in the history

  16. Small number of tests for BoxedUint prime generation

    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c2ea4c1 View commit details
    Browse the repository at this point in the history

  17. Attempted to implement UintLike for BoxedUint; identified missing imp… 

    …lementation in crypto-bigint
    @xuganyu96
    xuganyu96 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    a958b30 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. This thing compiles but does not pass tests

    @xuganyu96
    xuganyu96 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2ed2bda View commit details
    Browse the repository at this point in the history

  2. Separate out failed prime generation test

    @xuganyu96
    xuganyu96 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3674e87 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Use overflowing_shift to allow overflow

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    fa86383 View commit details
    Browse the repository at this point in the history

  2. instantiate one using precision so shifting works

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    8edacf8 View commit details
    Browse the repository at this point in the history

  3. Widen raw before instantiating BoxedResidue

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    4c800d8 View commit details
    Browse the repository at this point in the history

  4. div_by_2 has been implemented

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    83d34e7 View commit details
    Browse the repository at this point in the history

  5. Widen after calling from

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    acc1f46 View commit details
    Browse the repository at this point in the history

  6. Refresh seems to address the problem with BoxedResidue::square; now g… 

    …enerate_prime and generate_safe_prime works with BoxedUint
    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    df0ec9b View commit details
    Browse the repository at this point in the history

  7. Removed unnecessary dbg!

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    49d3487 View commit details
    Browse the repository at this point in the history

  8. Removed refresh as BoxedUint::{square, mul} will return reduced form

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    24e9dde View commit details
    Browse the repository at this point in the history

  9. Better clarity

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    bf76fe5 View commit details
    Browse the repository at this point in the history

  10. BoxedUint test for lucas

    @xuganyu96
    xuganyu96 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    459089d View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Adapted to newest crypto-bigint APIs

    @xuganyu96
    xuganyu96 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7d7563a View commit details
    Browse the repository at this point in the history