Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: env0 Organization creation via provider #1013

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Feat: env0 Organization creation via provider #1013

merged 2 commits into from
Feb 27, 2025

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #1012

Solution

  1. Add new API calls.
  2. Added unit tests for new API calls.
  3. Added new resource.
  4. Added acceptance tests for new resource.
  5. Added an example.

Did not add a harness test for creating an organization! There's no option to delete an organization.

@TomerHeber TomerHeber self-assigned this Feb 19, 2025
@TomerHeber
Copy link
Collaborator Author

TomerHeber commented Feb 19, 2025 •
edited
Loading

The API key doesn't have permission to view/use/create the new organization even though it's admin scope.

@yaronya yaronya merged commit 59d3a48 into main Feb 27, 2025
5 checks passed
@yaronya yaronya deleted the feat-org-creation-#1012 branch February 27, 2025 08:14
@github-actions github-actions bot added the ready to merge PR approved - can be merged once the PR owner is ready label Feb 27, 2025
@omry-hay
Copy link
Contributor

@yaronya I think we don't allow creating organizations using an API key for a reason.
@HeverFarber I think you talked about it with @Constantine19.
So I think we should revert this PR.

cc @TomerHeber ☝️

HeverFarber added a commit that referenced this pull request Feb 27, 2025
@HeverFarber
Revert "Feat: env0 Organization creation via provider (#1013)"
60d665a 
This reverts commit 59d3a48.
@HeverFarber HeverFarber mentioned this pull request Feb 27, 2025
Merged
yaronya pushed a commit that referenced this pull request Feb 27, 2025
@HeverFarber
Revert "Feat: env0 Organization creation via provider (#1013)" (#1018)
2b28877 
This reverts commit 59d3a48.
@yaronya
Copy link
Contributor

yaronya commented Feb 27, 2025 •
edited
Loading

@TomerHeber apologies for the confusion. I totally forgot that this is not allowed via API key.
I'll update the GH issue as well.

We've merged a revert PR: #1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaronya yaronya yaronya approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client blocked examples feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

env0 Organization creation via provider
3 participants
@TomerHeber @omry-hay @yaronya