Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragile relation between slices added in partitioner and slice number used in laik_map #1

Open
weidendo opened this issue Mar 11, 2018 · 0 comments

Comments

@weidendo
Copy link
Contributor

Currently, LAIK LULESH seems to assume that the ordering of slices as they added to the partitioning in the partitioner algorithm defines the slice numbers.

However, slice numbers are just meant to be local indexes in an iteration loop when the application wants to go through all slices, to just be consumed locally be laik_my_slice and laik_map.

So the current code may work at the moment, but it is very fragile and may get wrong when changing small implementation details in LAIK (such as not using a stable sorting algorithm internally when post-processing the slices added by a partitioner).

In addition, slight changes in the partitioner result in all laik_map calls to become wrong.

Solutions:

  • ask LAIK to return the correct slice, depending on a global index in the index space
  • use the introduced tag numbers to identify the same slice/slice group
@weidendo weidendo changed the title Fragile relation between slices added in partitioner and slice number used in lack_map Fragile relation between slices added in partitioner and slice number used in laik_map Mar 11, 2018
amir-raoofy added a commit that referenced this issue Jan 7, 2019
	- laik_vector_<#1>_<#2>_<#3>
	  #1 whether it the vector is used for underlying communication (comm) of repartitioning (repart)
	  #2 p1, it can be exclusive, halo or overlapping partitioning
	  #3 p2 if it is different from p1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant