Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Skip on handler in Velodrome Indexer #289

Open
jfarid27 opened this issue Oct 24, 2024 · 5 comments
Open

Event Skip on handler in Velodrome Indexer #289

jfarid27 opened this issue Oct 24, 2024 · 5 comments
Assignees
Labels
Bug Something isn't working

Comments

@jfarid27
Copy link

Describe the bug

In the Reproduce section there is a state that reproduces a bug, where an event is not being captured at a specific block on Base. The details:

  1. In this setup in the config.yaml, the Base indexer's start block is 14192630.

  2. The exact block we are trying to capture is located 14192634. The on chain event is Pool Created located here: https://basescan.org/tx/0x8060b54a0cab5cf1710521a29dc31354b08a1c450832d7141b417cc801da0742#eventlog.

  3. Later in block 14192694, a PoolSwap event is emitted, and in the loader it looks for the PoolCreated event. Strangely, it cannot find the entity, and it causes the indexer to fail. This shouldn't happen since the PoolCreated event should have fired and stored the data.

To Reproduce

  1. Download Bugfix/demo missing poolcreated velodrome-indexer#157 this PR sets up the bug.
  2. Run the PR. It is expected that the Pool Created event fires.
  3. The event will fail during a pool swap, after looking for the Pool Created event. Console.logs will be dumped, but the PoolCreated event will not show console.log or context.debug events, showing the handler doesn't fire. This is causing the bug in the swap event as it cannot find the pool during the loader call.

Expected behavior

PoolCreated should fire on block 14192634.

Screenshots

The Linked PR should be enough to test, please download enviodev/velodrome-indexer#157 and run the indexer.

Local (please complete the following information):

  • Envio version 2.4.4
  • Node version v20.17.0
  • pnpm version 9.11.0
  • Docker version 27.3.1, build ce12230

Hosted Service (please complete the following information):

Additional context
Chatted with @moose-code on the issue. Will end up pushing a bugfix in the velodrome-indexer just to get the indexer running again which will just log the error, but the goal will probably be to get the event firing.

@chrisais9
Copy link

May related to #286

@jfarid27
Copy link
Author

May related to #286

Yeah Jon Jon did exactly mention that. He said to make this issue at least to document the error scenario.

@JonoPrest JonoPrest self-assigned this Oct 25, 2024
@JonoPrest JonoPrest added the Bug Something isn't working label Oct 25, 2024
@JonoPrest
Copy link
Collaborator

@jfarid27, there have been a few fixes in the last two days that could have contributed to this. I haven't rerun your indexer at the branch you shared yet and the linked deployment is gone from the hosted service.

If the issue is persisting with 2.6.1 then I will look into this on Monday 🙏🏼

@moose-code
Copy link
Contributor

I've just deployed another version on v2.6.1 on the hosted service so we can validate thanks @JonoPrest
https://envio.dev/app/enviodev/velodrome-indexer/866f822

cc @jfarid27

@moose-code
Copy link
Contributor

Sorry just realized I bumped main and haven't deployed the erroneous branch. Will do that too now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants