Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 1.5.1 #24

Open
orslumen opened this issue Apr 8, 2011 · 1 comment
Open

jQuery 1.5.1 #24

orslumen opened this issue Apr 8, 2011 · 1 comment

Comments

@orslumen
Copy link

orslumen commented Apr 8, 2011

Some fixes were needed to get jQuery 1.5.1 working with EnvJs in Ruby Racer:

i) The jQuery.clone method uses an expando attribute that is removed in jQeury.cloneFixAttributes. But that attribute may not be present on the current node. If doc.implementation.errorChecking === false it should fail silently, see NamedNodeMap#removeNamedItem(NS).

ii) jQuery directly retrieves and sets the value attribute on the nodes, but (at least in Ruby Racer) the NamedNodeMap does not accept a call to value=. To fix this, explicit getter and setters are added, see NamedNodeMap#get/set value

iii) jQeury.cloneFixAttributes makes use of Element.clearAttributes and Element.mergeAttributes. Both methods were not defined yet.

The code changes I used to get jQuery 1.5.1 working can be found in orslumen@c3e702c

@vanm
Copy link

vanm commented Jun 14, 2011

@orslumen Thanks for publishing these fixes. If you haven't created a pull request already, it would be great to get these pulled back into envjs master.

SkUrRiEr pushed a commit to SkUrRiEr/env-js that referenced this issue Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants