Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Better handle multiple instances of Timers #3

Open
cafreeman opened this issue Jun 30, 2018 · 0 comments
Open

Better handle multiple instances of Timers #3

cafreeman opened this issue Jun 30, 2018 · 0 comments

Comments

@cafreeman
Copy link
Contributor

Right now, gjallarhorn is completely naive about the fact that the Performance API will gladly create multiple measures for the same set of marks. It just grabs the very first one every time, which means that if you create multiple timers with the same marks and don't call clear(), you'll get trolled by the fact that you'll only ever see one instance of that Timer's measures.

I'd like to handle this by also creating some kind of hash that we track internally to differentiate the marks, while keeping the labels clean.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant