Remove duplicate linters and use gci for imports #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomly was reading through this repo and found this potential cleanup, feel free to reject if not needed
gofmt
andgofumpt
fully overlap, so removegofmt
linter sincegofumpt
is more advancedgci
andgoimports
fully overlap, so removegoimports
linter sincegci
is more avanced.goimports
, can do the reverse, but I don't recommend it since it formats much worse IMOgoimports
withgci
in Makefile to correspond to above changeawk
hack since not needed forgci
goimports
instead ofgci
, basically both Makefile and golangci.yml should define the same thingA change that came to mind but was larger than the above was replacing manual invocation of
gofumpt
andgci
in Makefile withgolangci-lint run --fix
, which works very similarly because it is configured for the two. I personally like it since it means no need to reproduce configuration from yaml file into Makefile (notably the local import prefix). The downside is it would be a bit slower, so also understand why not everyone would want to do that.