Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update, and add testing for the envoy-filter-example and/or make into a sandbox #28606

Open
phlax opened this issue Jul 25, 2023 · 3 comments
Open
Labels
area/envoy-filter-example area/examples help wanted Needs help! no stalebot Disables stalebot from closing an issue

Comments

@phlax
Copy link
Member

phlax commented Jul 25, 2023

Currently we use the envoy-filter-example in CI but i think only as an external workspace to test building from (im guessing that was why it was set that way)

It seems the actual example is not getting tested and possibly doesnt work as expected

We could probably make it into a sandbox and add testing/documentation to ensure it stays working

@shiponcs
Copy link
Contributor

Adding this https://envoyproxy.slack.com/archives/C78HA81DH/p1690280066893899 so that people can later understand what triggers this idea.

@shiponcs
Copy link
Contributor

Here is a related issue: envoyproxy/envoy-filter-example#178

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 24, 2023
@phlax phlax added help wanted Needs help! no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/envoy-filter-example area/examples help wanted Needs help! no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

2 participants