From a6f0b60b1da8614e31544b113af8fb63e4ac5477 Mon Sep 17 00:00:00 2001 From: Huabing Zhao Date: Mon, 9 Dec 2024 06:44:33 +0000 Subject: [PATCH] update release note Signed-off-by: Huabing Zhao --- internal/provider/kubernetes/controller.go | 7 +++++-- internal/provider/kubernetes/kubernetes.go | 2 +- internal/provider/kubernetes/status_updater.go | 2 +- release-notes/current.yaml | 11 ++++++----- 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/internal/provider/kubernetes/controller.go b/internal/provider/kubernetes/controller.go index 8091964bfd1..0685f228bf3 100644 --- a/internal/provider/kubernetes/controller.go +++ b/internal/provider/kubernetes/controller.go @@ -135,7 +135,10 @@ func newGatewayAPIController(mgr manager.Manager, cfg *config.Server, su Updater controller.Options{ Reconciler: r, SkipNameValidation: skipNameValidation(), - NewQueue: func(_ string, _ workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] { + NewQueue: func( + _ string, + _ workqueue.TypedRateLimiter[reconcile.Request], + ) workqueue.TypedRateLimitingInterface[reconcile.Request] { return queue }, }) @@ -152,8 +155,8 @@ func newGatewayAPIController(mgr manager.Manager, cfg *config.Server, su Updater return nil, fmt.Errorf("error watching resources: %w", err) } - // Trigger a resync of the controller return func() { + // Trigger a reconciliation to update the status of all resources. queue.AddRateLimited(reconcile.Request{}) }, nil } diff --git a/internal/provider/kubernetes/kubernetes.go b/internal/provider/kubernetes/kubernetes.go index eb84d593f21..7b9b3c46279 100644 --- a/internal/provider/kubernetes/kubernetes.go +++ b/internal/provider/kubernetes/kubernetes.go @@ -100,7 +100,7 @@ func New(cfg *rest.Config, svr *ec.Server, resources *message.ProviderResources) return nil, fmt.Errorf("failted to create gatewayapi controller: %w", err) } - // Trigger a resync after updateHandler is started to ensure we don't miss any updates. + // Trigger a reconciliation after updateHandler is started to ensure we don't miss any updates. updateHandler.addPostStart(resync) // Add health check health probes. diff --git a/internal/provider/kubernetes/status_updater.go b/internal/provider/kubernetes/status_updater.go index 8a215d34c15..cf76d9fe1f6 100644 --- a/internal/provider/kubernetes/status_updater.go +++ b/internal/provider/kubernetes/status_updater.go @@ -137,7 +137,7 @@ func (u *UpdateHandler) Start(ctx context.Context) error { // Enable Updaters to start sending updates to this handler. close(u.sendUpdates) - // Trigger a resync to ensure we don't miss any updates. + // Trigger a reconciliation to ensure we don't miss any updates. if u.postStart != nil { u.postStart() } diff --git a/release-notes/current.yaml b/release-notes/current.yaml index b2bfc794438..90909a2f6b8 100644 --- a/release-notes/current.yaml +++ b/release-notes/current.yaml @@ -12,13 +12,14 @@ security updates: | # New features or capabilities added in this release. new features: | - Added support for trusted CIDRs in the ClientIPDetectionSettings API - Added support for sending attributes to external processor in EnvoyExtensionPolicy API + Added support for trusted CIDRs in the ClientIPDetectionSettings API. + Added support for sending attributes to external processor in EnvoyExtensionPolicy API. # Fixes for bugs identified in previous versions. bug fixes: | - Fixed BackendTLSPolicy didn't support using port name as the sectionName in the targetRefs - Fixed reference grant from EnvoyExtensionPolicy to referenced ext-proc backend not respected + Fixed BackendTLSPolicy didn't support using port name as the sectionName in the targetRefs. + Fixed reference grant from EnvoyExtensionPolicy to referenced ext-proc backend not respected. + Fixed Envoy proxies connected to the secondary gateway didn't receive configuration. # Enhancements that improve performance. performance improvements: | @@ -30,4 +31,4 @@ deprecations: | # Other notable changes not covered by the above sections. Other changes: | - [SecurityPolicy] Modify the JWT Provider Issuer validation constraint + [SecurityPolicy] Modify the JWT Provider Issuer validation constraint.