Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EnvoyExtensionPolicy reference grant #4851

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Dec 5, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4846

Release Notes: Yes/No

@guydc guydc requested a review from a team as a code owner December 5, 2024 01:02
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.92%. Comparing base (226082b) to head (75aa104).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/indexers.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4851      +/-   ##
==========================================
+ Coverage   65.67%   65.92%   +0.25%     
==========================================
  Files         211      211              
  Lines       32064    32065       +1     
==========================================
+ Hits        21059    21140      +81     
+ Misses       9761     9681      -80     
  Partials     1244     1244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guydc guydc merged commit 905405e into envoyproxy:main Dec 5, 2024
24 checks passed
guydc added a commit to guydc/gateway that referenced this pull request Dec 12, 2024
* fix: EnvoyExtensionPolicy reference grant

Signed-off-by: Guy Daich <[email protected]>

* fix lint, add release note

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit 905405e)
Signed-off-by: Guy Daich <[email protected]>
guydc added a commit that referenced this pull request Dec 12, 2024
* fix: EnvoyExtensionPolicy reference grant (#4851)

* fix: EnvoyExtensionPolicy reference grant

Signed-off-by: Guy Daich <[email protected]>

* fix lint, add release note

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit 905405e)
Signed-off-by: Guy Daich <[email protected]>

* fix: Gateway-target BTP ignored when route timeout defined (#4860)

* fix: Gateway-target BTP ignored when route timeout defined

Signed-off-by: Guy Daich <[email protected]>

* fix gen, add note

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit e6fce34)
Signed-off-by: Guy Daich <[email protected]>

* build(deps): bump golang.org/x/crypto from 0.30.0 to 0.31.0 (#4901)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.30.0 to 0.31.0.
- [Commits](golang/crypto@v0.30.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit d71ba7b)
Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
zhaohuabing pushed a commit to zhaohuabing/gateway that referenced this pull request Dec 13, 2024
* fix: EnvoyExtensionPolicy reference grant

Signed-off-by: Guy Daich <[email protected]>

* fix lint, add release note

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit 905405e)
Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnvoyExtensionPolicy -> Backend ReferenceGrant is ignored
3 participants