Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable IPv6 test #4852

Closed
wants to merge 1 commit into from
Closed

Conversation

zirain
Copy link
Member

@zirain zirain commented Dec 5, 2024

No description provided.

@zirain zirain requested a review from a team as a code owner December 5, 2024 01:49
@zirain zirain force-pushed the ipv6-enable-test-bak branch from a15b2a2 to cda4431 Compare December 5, 2024 01:50
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (e6d3526) to head (9a19e1a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4852      +/-   ##
==========================================
+ Coverage   65.68%   65.70%   +0.02%     
==========================================
  Files         211      211              
  Lines       32064    32064              
==========================================
+ Hits        21060    21069       +9     
+ Misses       9761     9754       -7     
+ Partials     1243     1241       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -16,6 +16,7 @@ metadata:
name: proxy-config
namespace: envoy-gateway-system
spec:
ipFamily: $ENVOY_PROXY_IP_FAMILY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat idea :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bad news is that we need move all EnvoyProxy resources to this file.

@zirain zirain force-pushed the ipv6-enable-test-bak branch from 950e040 to 3e5dd3d Compare December 5, 2024 04:03
Signed-off-by: zirain <[email protected]>
@zirain zirain force-pushed the ipv6-enable-test-bak branch from 33e18ce to 9a19e1a Compare December 5, 2024 06:29
@zirain
Copy link
Member Author

zirain commented Dec 5, 2024

#4853 is better

@zirain zirain closed this Dec 5, 2024
@zirain zirain deleted the ipv6-enable-test-bak branch December 5, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants