fix: Gateway-target BTP ignored when route timeout defined #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
=======================================
Coverage 66.28% 66.29%
=======================================
Files 209 209
Lines 31956 31923 -33
=======================================
- Hits 21182 21163 -19
+ Misses 9525 9515 -10
+ Partials 1249 1245 -4 ☔ View full report in Codecov by Sentry. |
|
looks good thanks, does the unit test cover the regression (overriden policy attached to Gateway + timeout specified in HTTPRoute)? |
Yea. |
guydc
added a commit
to guydc/gateway
that referenced
this pull request
Dec 12, 2024
…y#4860) * fix: Gateway-target BTP ignored when route timeout defined Signed-off-by: Guy Daich <[email protected]> * fix gen, add note Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit e6fce34) Signed-off-by: Guy Daich <[email protected]>
guydc
added a commit
that referenced
this pull request
Dec 12, 2024
* fix: EnvoyExtensionPolicy reference grant (#4851) * fix: EnvoyExtensionPolicy reference grant Signed-off-by: Guy Daich <[email protected]> * fix lint, add release note Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit 905405e) Signed-off-by: Guy Daich <[email protected]> * fix: Gateway-target BTP ignored when route timeout defined (#4860) * fix: Gateway-target BTP ignored when route timeout defined Signed-off-by: Guy Daich <[email protected]> * fix gen, add note Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit e6fce34) Signed-off-by: Guy Daich <[email protected]> * build(deps): bump golang.org/x/crypto from 0.30.0 to 0.31.0 (#4901) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.30.0 to 0.31.0. - [Commits](golang/crypto@v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit d71ba7b) Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Dec 13, 2024
…y#4860) * fix: Gateway-target BTP ignored when route timeout defined Signed-off-by: Guy Daich <[email protected]> * fix gen, add note Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit e6fce34) Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Returns the Gateway-API
HTTPRoutetimeout to theRouteIR struct, extracting it from theTrafficFeaturesstruct. Both HTTPRoute and BTP may define a route timeout. Instead of merging during IR calculation, both values are now saved in IR. The effective route timeout is calculated in XDS translation, giving precedence to GW-API settings.This simplifies merging logic and makes it easy to identify routes that a gateway-level policy should be applied to.
Which issue(s) this PR fixes:
Fixes #4844
Release Notes: Yes/No