fix: trigger a resync to avoid missing any status updates

[zhaohuabing]

This PR does two things:

• Remove wait to make sure the status updater won't block the reconcile loop in a non-leader scenario.
• Trigger a reconciliation after starting the status updater to avoid missing any status updates.

Fixes: #4845

Release Note: Yes

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (05ee5f4) to head (a6f0b60).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/provider/kubernetes/controller.go	91.66%	2 Missing ⚠️
internal/provider/kubernetes/kubernetes.go	75.00%	0 Missing and 1 partial ⚠️
internal/provider/kubernetes/status_updater.go	95.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4878   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files         209      209           
  Lines       31956    31987   +31     
=======================================
+ Hits        21191    21212   +21     
- Misses       9518     9525    +7     
- Partials     1247     1250    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arkodg]

@zhaohuabing I dont think this will solve the original problem because the re sync will not trigger the status watchable subscribed handler to get any updates, because nothing would have changed ( in the watchable store), so the original problem of missing status updates will still persist

[arkodg]

my suggestion would be to

1. always push status updates via watchable, which was implemented in fix: decouple gateway status updates from the reconciler #4767
   and
2. we should block the status updater watchable subscribe goroutine similar to

   gateway/internal/infrastructure/runner/runner.go

   Line 70 in 9ef758b

   // When leader election is active, infrastructure initialization occurs only upon acquiring leadership

   and only enable it once its part of the controller thats the leader
   wdyt @alexwo @guydc

[alexwo]

my suggestion would be to

1. always push status updates via watchable, which was implemented in fix: decoup gateway status updates from the reconciler #4767
   and
2. we should block the status updater watchable subscribe goroutine similar to

   gateway/internal/infrastructure/runner/runner.go

   Line 70 in 9ef758b

   // When leader election is active, infrastructure initialization occurs only upon acquiring leadership

   
   and only enable it once its part of the controller thats the leader
   wdyt @alexwo @guydc

+1 sounds good to me.