Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a default memory limit for shutdown-manager #4882

Open
ryanhristovski opened this issue Dec 9, 2024 · 1 comment
Open

Define a default memory limit for shutdown-manager #4882

ryanhristovski opened this issue Dec 9, 2024 · 1 comment
Labels
kind/decision A record of a decision made by the community.
Milestone

Comments

@ryanhristovski
Copy link

Description:
Currently the shutdown-manager sidecar does not have a default memory limit set, this can lead to uncontrolled memory usage, potentially causing node instability or OOMKilled errors. It's best practice to set the memory request equal to the memory limit to ensure consistent resource allocation and avoid unexpected scheduling issues.

I haven't yet benchmarked shutdown-managers memory usage to have a good idea of what to set the request/limit to if anyone has any suggestions.

@arkodg
Copy link
Contributor

arkodg commented Dec 9, 2024

requests == limit sgtm, wdyt @envoyproxy/gateway-maintainers @envoyproxy/gateway-reviewers

@arkodg arkodg added the kind/decision A record of a decision made by the community. label Dec 9, 2024
@arkodg arkodg added this to the v1.3.0-rc.1 milestone Dec 9, 2024
@arkodg arkodg removed the triage label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/decision A record of a decision made by the community.
Projects
None yet
Development

No branches or pull requests

2 participants