Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.2] Add registry for envoy proxy image #4886

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Dec 10, 2024

No description provided.

@arkodg arkodg requested a review from a team as a code owner December 10, 2024 19:00
@arkodg arkodg requested a review from a team December 10, 2024 19:00
@arkodg arkodg added cherrypick/release-v1.2.4 kind/bug Something isn't working labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.59%. Comparing base (f5e7bd6) to head (5b4c5bd).
Report is 1 commits behind head on release/v1.2.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.2    #4886      +/-   ##
================================================
+ Coverage         65.57%   65.59%   +0.02%     
================================================
  Files               211      211              
  Lines             31984    31984              
================================================
+ Hits              20972    20979       +7     
+ Misses             9767     9760       -7     
  Partials           1245     1245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@arkodg arkodg merged commit f52cdd0 into envoyproxy:release/v1.2 Dec 11, 2024
18 checks passed
@arkodg arkodg deleted the fix-registry-ep branch December 11, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants