Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: organize go.mod require sections #4893

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

shahar-h
Copy link
Contributor

What this PR does / why we need it:
Since currently there are mixed direct and indirect dependencies inside go.mod require sections go mod tidy creates a new section each time. See reference.

Before this change there were 4 require sections. now there are 2 - one with direct dependencies and one with indirect dependencies, as expected.

Release Notes: No

@shahar-h shahar-h requested a review from a team as a code owner December 11, 2024 18:16
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (507ea5d) to head (a9118eb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4893   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files         209      209           
  Lines       31922    31922           
=======================================
+ Hits        21150    21151    +1     
- Misses       9521     9522    +1     
+ Partials     1251     1249    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@shahar-h
Copy link
Contributor Author

/retest

@arkodg arkodg merged commit 86f869f into envoyproxy:main Dec 12, 2024
24 of 26 checks passed
@shahar-h shahar-h deleted the fix-go-mod branch December 12, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants