Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix osv license scan config and add license override #4906

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

shahar-h
Copy link
Contributor

@shahar-h shahar-h commented Dec 12, 2024

What this PR does / why we need it:

  • Fix file name in --config arg - I used yaml instead of toml by mistake.
  • Comment out vulnerability.ignore flag which was added here since it's only supported in osv-scanner v1.9.1. The current osv-scanner-action is v1.9.0. I opened an issue to release a new version.
  • Add license override for golang.org/x/crypto since it doesn't appear yet on deps.dev.
    Opened an issue.

BTW the workflow didn't fail because 127 status code is redirected to 0 when running inside osv-scanner container.
I opened an issue a long time ago.

Release Notes: No

@shahar-h shahar-h requested a review from a team as a code owner December 12, 2024 07:20
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (9b60a67) to head (6b7d68c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4906   +/-   ##
=======================================
  Coverage   66.24%   66.25%           
=======================================
  Files         209      209           
  Lines       31922    31922           
=======================================
+ Hits        21148    21151    +3     
+ Misses       9523     9522    -1     
+ Partials     1251     1249    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shahar Harari <[email protected]>
Signed-off-by: Shahar Harari <[email protected]>
@shahar-h
Copy link
Contributor Author

image

@shahar-h
Copy link
Contributor Author

/retest

Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@guydc guydc merged commit 507ea5d into envoyproxy:main Dec 12, 2024
24 checks passed
@shahar-h shahar-h deleted the osv-fix branch December 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants