Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support patching on EnvoyProxy.spec.provider.kubernetes.envoyHpa and EnvoyProxy.spec.provider.kubernetes.envoyPDB #4910

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

keithfz
Copy link

@keithfz keithfz commented Dec 12, 2024

What type of PR is this?

This is an enhancement to enable a patch option for EnvoyProxy.spec.provider.kubernetes.envoyHpa and EnvoyProxy.spec.provider.kubernetes.envoyPDB in the EnvoyProxy API.

What this PR does / why we need it:
This PR adds a patch field for EnvoyProxy.spec.provider.kubernetes.envoyHpa and EnvoyProxy.spec.provider.kubernetes.envoyPDB. To apply the patch, we use the same mechanism that we use for patching other resources in the EnvoyProxy API, such as envoyDeployment, envoyDaemonSet, and envoyService.

Which issue(s) this PR fixes:

Fixes #4894

Release Notes: Yes

@keithfz keithfz requested a review from a team as a code owner December 12, 2024 22:02
@arkodg arkodg requested a review from a team December 13, 2024 02:11
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 36 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (d33b617) to head (de3dcce).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/v1alpha1/kubernetes_helpers.go 59.25% 16 Missing and 6 partials ⚠️
...frastructure/kubernetes/proxy/resource_provider.go 46.66% 5 Missing and 3 partials ⚠️
api/v1alpha1/validation/envoyproxy_validate.go 80.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4910      +/-   ##
==========================================
- Coverage   66.28%   66.26%   -0.03%     
==========================================
  Files         209      209              
  Lines       31942    32035      +93     
==========================================
+ Hits        21172    21227      +55     
- Misses       9517     9546      +29     
- Partials     1253     1262       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keithfz
Copy link
Author

keithfz commented Dec 13, 2024

bleh - apologies on the lint stuff, first time working in this repo 😄

@arkodg
Copy link
Contributor

arkodg commented Dec 13, 2024

np thanks for the quick PR, will try and review this by EOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support patching on EnvoyProxy.spec.provider.kubernetes.envoyHpa and envoyPDB
2 participants