Fix Weighted Invalid Backend Logic #4911
Merged
+18
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not adding valid clusters where there was a invalid cluster Regression from envoyproxy#3246 Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4911 +/- ##
==========================================
+ Coverage 66.27% 66.33% +0.05%
==========================================
Files 209 209
Lines 31922 31942 +20
==========================================
+ Hits 21156 21188 +32
+ Misses 9518 9506 -12
Partials 1248 1248 ☔ View full report in Codecov by Sentry. |
zhaohuabing
previously approved these changes
Dec 13, 2024
Signed-off-by: Arko Dasgupta <[email protected]>
zhaohuabing
approved these changes
Dec 13, 2024
zirain
approved these changes
Dec 13, 2024
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Dec 13, 2024
* Fix Weighted Invaid Backend Logic We were not adding valid clusters where there was a invalid cluster Regression from envoyproxy#3246 Signed-off-by: Arko Dasgupta <[email protected]> * add release note Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit b9ff29c) Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not adding valid clusters where there was a invalid cluster
Regression from #3246