bugfix: optimize routes status unnecessary deepcopy. #4527
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4527 +/- ##
==========================================
+ Coverage 65.72% 65.75% +0.03%
==========================================
Files 211 211
Lines 31669 31623 -46
==========================================
- Hits 20813 20795 -18
+ Misses 9656 9627 -29
- Partials 1200 1201 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: qicz <[email protected]>
|
/retest |
| @@ -66,16 +66,20 @@ func (r *gatewayAPIReconciler) subscribeAndUpdateStatus(ctx context.Context, ext | |||
| r.statusUpdater.Send(Update{ | |||
| NamespacedName: key, | |||
| Resource: new(gwapiv1.HTTPRoute), | |||
| Mutator: MutatorFunc(func(obj client.Object) client.Object { | |||
| Mutator: MutatorFunc(func(obj client.Object) bool { | |||
There was a problem hiding this comment.
the API is for mutating obects but is now returning a bool ? this doesnt seem right
There was a problem hiding this comment.
changed this api to boolean
There was a problem hiding this comment.
What is the new definition for the mutator function
|
can you the memory diff before-after? |
I think we should deal this after #4498 (comment) That's comparable with the same way |
| } | ||
|
|
||
| // MutatorFunc is a function adaptor for Mutators. | ||
| type MutatorFunc func(client.Object) client.Object | ||
| type MutatorFunc func(client.Object) bool |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part Fixes #4516
Release Notes: Yes/No