fix: btlsp section name doesn't support port name #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
changed the title
zhaohuabing
changed the title
zhaohuabing
force-pushed
the
fix-btlsp-section-name
branch
from
153fd00
to
454d292
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4784 +/- ##
==========================================
- Coverage 65.59% 65.59% -0.01%
==========================================
Files 211 211
Lines 32001 32024 +23
==========================================
+ Hits 20992 21005 +13
- Misses 9767 9775 +8
- Partials 1242 1244 +2 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
fix-btlsp-section-name
branch
from
454d292
to
97289e5
Compare
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-btlsp-section-name
branch
from
19a4814
to
1536c2a
Compare
zhaohuabing
commented
Nov 26, 2024
arkodg
reviewed
Nov 27, 2024
arkodg
reviewed
Nov 27, 2024
| target := getTargetBackendReference(backendRef) | ||
| for _, policy := range policies { | ||
| if backendTLSTargetMatched(*policy, target, backendNamespace) { | ||
| return policy | ||
| } | ||
| } | ||
|
|
||
| // SectionName can be port name for Kubernetes Service | ||
| target = getTargetBackendReferenceWithPortName(backendRef, backendNamespace, resources) |
There was a problem hiding this comment.
why do we need another new function
isnt there logic already for this in
There was a problem hiding this comment.
This function uses port name instead of port number as sectionName to match policy.
There was a problem hiding this comment.
lets support port number - section name matching for Backend and only port name - section name matching for Service, this ensures the user config can be safely migrated and tested in other controllers
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4769
This PR allows using port name as the
sectionNamefor the targetRefs of theBackendTLSPolicy.The support for port number has been retained because:
BackendAPI, which doesn't have a name for its portRelease Notes: Yes