-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow hostname to use subdomain with single label/character #4803
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Taufik Mulyana <[email protected]>
@nothinux Thanks for fixing this! Could you please add a test to test/cel-validation/backend_test.go? |
Signed-off-by: Taufik Mulyana <[email protected]>
added |
Signed-off-by: Taufik Mulyana <[email protected]>
@zhaohuabing the coverage test failed because only 4 items are allowed. can we double this limit? gateway/api/v1alpha1/backend_types.go Lines 119 to 121 in a383dd9
|
I think it's fine to make it 8 cc @guydc |
64, so it account for cases where users are auto generating Backend resources to route to custom backends ? Can we do that in a separate PR @nothinux ? |
Fixes #4793
Release Notes: