Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modify_col_def consistent with other functions #60

Open
TymekDev opened this issue Dec 9, 2024 · 1 comment
Open

Make modify_col_def consistent with other functions #60

TymekDev opened this issue Dec 9, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@TymekDev
Copy link

TymekDev commented Dec 9, 2024

Hey! I have been exploring the package a bit and couldn't help but notice that naming on modify_col_def is out of place. What do you think about changing it to set_column_options, update_column_option, or update_column_definition?

Additionally, is there any particular reason why it takes a col_update list over ellipsis (...)? Perhaps it could support both?

@crazycapivara crazycapivara self-assigned this Dec 14, 2024
@crazycapivara crazycapivara added the enhancement New feature or request label Dec 14, 2024
@crazycapivara
Copy link
Contributor

@TymekDev Your are absolutely right. The modify_col_def function was made public by accident in the latest dev version.
In the next release there will be a set_column function that allows to set formatters and editors for multiple columns at once. Seel also the PR #59. The ... will then also be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants