Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The reaction with catalysts is displayed incorrect with ACS style setting and after layout (ketcher part) #5954

Closed
AlexeyGirin opened this issue Nov 11, 2024 · 0 comments · Fixed by #5991
Closed

The reaction with catalysts is displayed incorrect with ACS style setting and after layout (ketcher part) #5954

AlexeyGirin opened this issue Nov 11, 2024 · 0 comments · Fixed by #5991
Assignees
@mnmsvlw
Labels
ACS standard bug Layout Priority: High Team G
Milestone
Ketcher 2.28.0-rc...

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Nov 11, 2024 •
edited
Loading

Follow up on epam/Indigo#2458 ()

Steps to Reproduce

  1. add reaction to the Canvas
    error with cat and arr.ket.zip
Screenshot 2024-10-01 at 14 04 58
  1. click on ACS Style button in the Settings
  2. click on Apply button in the Settings
  3. click on layout

Actual behavior
Spacing between letters on the canvas twice more than on the PNG:
Canvas:
image
PNG:
image

Expected behavior
Spacing between letter on the canvas should be the same as in PNG

Environment details:

  • Ketcher Version 2.26.0-rc.9 Build at 2024-11-11; 12:01:35
  • Indigo Toolkit Version 1.25.0-rc.5.0-g45d28b8ca-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.117 (Official Build) (64-bit)
  • Win10

Issues for epam/Indigo#2176
@AlexeyGirin AlexeyGirin modified the milestones: Ketcher 2.27.0-rc.2, Ketcher 2.26.0-rc.10 Nov 11, 2024
@AlexeyGirin AlexeyGirin mentioned this issue Nov 11, 2024
Closed
@rrodionov91 rrodionov91 modified the milestones: Ketcher 2.26.0-rc.10, Ketcher 2.28.0-rc.1 (Current) Nov 12, 2024
mnmsvlw added a commit that referenced this issue Nov 19, 2024
@mnmsvlw
#5954 - the reaction with catalysts is displayed incorrect with acs s…
a30864c 
…tyle setting and after layout ketcher part
@mnmsvlw mnmsvlw linked a pull request Nov 19, 2024 that will close this issue
#5954 – The reaction with catalysts is displayed incorrect with ACS style setting and after layout (ketcher part) #5991
Merged
9 tasks
mnmsvlw added a commit that referenced this issue Nov 21, 2024
@mnmsvlw
#5954 - the reaction with catalysts is displayed incorrect with acs s…
12b8641 
…tyle setting and after layout ketcher part
mnmsvlw added a commit that referenced this issue Nov 22, 2024
@mnmsvlw
#5954 - the reaction with catalysts is displayed incorrect with acs s…
13260f8 
…tyle setting and after layout ketcher part
NataliaLoginova pushed a commit that referenced this issue Nov 24, 2024
@mnmsvlw
#5954 – The reaction with catalysts is displayed incorrect with ACS s…
a1e8e79 
…tyle setting and after layout (ketcher part) (#5991)

* #5954 - the reaction with catalysts is displayed incorrect with acs style setting and after layout ketcher part

* Update molecules mode screenshots

* Update macro mode screenshots

* Update test data

* Update tests

* Update screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnmsvlw mnmsvlw

Labels
ACS standard bug Layout Priority: High Team G
Projects
None yet
Milestone
Ketcher 2.28.0-rc.1 (Current)
3 participants
@rrodionov91 @AlexeyGirin @mnmsvlw