Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up create_stan_data()? #887

Closed
jamesmbaazam opened this issue Dec 11, 2024 · 1 comment · Fixed by #888
Closed

Split up create_stan_data()? #887

jamesmbaazam opened this issue Dec 11, 2024 · 1 comment · Fixed by #888

Comments

@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented Dec 11, 2024

I've been reviewing #871 to bring myself up to date with developments while I was away and I realise that create_stan_data() is getting quite long and difficult to parse. For one, it's combining two concerns: what I'd call static data creation and dynamic modelling of the initial growth. I would suggest pulling out the modeling of initial growth part (https://github.com/epiforecasts/EpiNow2/blob/main/R/create.R#L504-L524) as it will be easier to maintain and improve if need be and to point to. It only depends on data, seeding_time, and horizon and returns the prior_infections and prior_growth, making it quite focused. This is more of a maintenance issue than an enhancement and can be categorised as low priority.

Thoughts?

@sbfnk
Copy link
Contributor

sbfnk commented Dec 12, 2024

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants