-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move lengthscale prior to dist_spec
#890
base: main
Are you sure you want to change the base?
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if e2afb31 is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 01bfc98 is merged into main:
|
The vignettes show no meaningful change in results or number of divergent transitions. Benchmarks also show no significant change in performance. If this looks correct to people we can probably merge and explore further building on this. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 11f1dca is merged into main:
|
@seabbs Do you want to take this one? |
Description
This PR closes #878.
In order for there to be a prior choice that applies across applications it rescales the lengthscale with half the length of the time series as done in Riutort-Mayol et al. It also fixes the minimum to zero (for now) which was previously the default but changeable.
Todo before merging:
Todo after merging (future PRs):
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request