From 04c594a064a1cc542ba8154e9c27b92ec0c416f8 Mon Sep 17 00:00:00 2001
From: Andrea Vesterhus <andrea.vesterhus@bouvet.no>
Date: Tue, 25 Jun 2024 21:39:09 +0200
Subject: [PATCH 1/5] fix: sidebar collapse

---
 e2e/tests/plugin-view_selector-car_garage.spec.ts      | 4 ++--
 packages/dm-core-plugins/src/view_selector/Sidebar.tsx | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/e2e/tests/plugin-view_selector-car_garage.spec.ts b/e2e/tests/plugin-view_selector-car_garage.spec.ts
index f1d1aa73f..65da2eeb8 100644
--- a/e2e/tests/plugin-view_selector-car_garage.spec.ts
+++ b/e2e/tests/plugin-view_selector-car_garage.spec.ts
@@ -13,7 +13,7 @@ test('View selector - car garage', async ({ page }) => {
 
   await test.step('Collapse and expand sidebar', async () => {
     await page.getByRole('tab', { name: 'Self' }).click()
-    await page.getByRole('button', { name: 'Collapse' }).click()
+    await page.getByRole('button', { name: 'Collapse sidebar' }).click()
     await expect(page.getByRole('tab', { name: 'Self' })).not.toBeVisible()
     await expect(page.getByRole('tab', { name: 'Audi' })).not.toBeVisible()
     await expect(page.getByRole('tab', { name: 'Volvo' })).not.toBeVisible()
@@ -23,7 +23,7 @@ test('View selector - car garage', async ({ page }) => {
     )
     await page.getByRole('tab').first().click()
     await expect(page.getByLabel('Name')).toHaveValue('CarGarage')
-    await page.getByRole('button', { name: 'Expand' }).click()
+    await page.getByRole('button', { name: 'Expand sidebar' }).click()
     await expect(page.getByRole('tab', { name: 'Self' })).toBeVisible()
     await expect(page.getByRole('tab', { name: 'Audi' })).toBeVisible()
     await expect(page.getByRole('tab', { name: 'Volvo' })).toBeVisible()
diff --git a/packages/dm-core-plugins/src/view_selector/Sidebar.tsx b/packages/dm-core-plugins/src/view_selector/Sidebar.tsx
index c611a2a6c..7e856b62c 100644
--- a/packages/dm-core-plugins/src/view_selector/Sidebar.tsx
+++ b/packages/dm-core-plugins/src/view_selector/Sidebar.tsx
@@ -115,6 +115,7 @@ export const Sidebar = (props: {
       <SideBar.Footer style={{ display: 'flex', justifyContent: 'flex-end' }}>
         <CustomToggle expanded={isOpen}>
           <Button
+            aria-label={isOpen ? 'Collapse sidebar' : 'Expand sidebar'}
             onClick={() => setIsOpen(!isOpen)}
             variant='ghost_icon'
             color='secondary'

From 34bd713494058e1f7512edd4cc5f2fb390b9d7e9 Mon Sep 17 00:00:00 2001
From: Andrea Vesterhus <andrea.vesterhus@bouvet.no>
Date: Tue, 25 Jun 2024 22:09:13 +0200
Subject: [PATCH 2/5] fix: test bigger browser size in tests

---
 e2e/tests/plugin-explorer.spec.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/e2e/tests/plugin-explorer.spec.ts b/e2e/tests/plugin-explorer.spec.ts
index b77898e22..e985f4e5c 100644
--- a/e2e/tests/plugin-explorer.spec.ts
+++ b/e2e/tests/plugin-explorer.spec.ts
@@ -2,7 +2,10 @@ import { expect, test } from '@playwright/test'
 
 test.describe.configure({ mode: 'serial' })
 
-test.beforeEach(async ({ page }) => {
+test.beforeEach(async ({ page, browser }) => {
+  browser.newContext({
+    viewport: { width: 1920, height: 1024 },
+  })
   await page.goto('http://localhost:3000/')
   await page.getByRole('button', { name: 'data source DemoDataSource' }).click()
   await page.getByRole('button', { name: 'root package plugins' }).click()

From 06318d8cf76aaef112601b5d2cbe239d93dde1b8 Mon Sep 17 00:00:00 2001
From: Andrea Vesterhus <andrea.vesterhus@bouvet.no>
Date: Wed, 26 Jun 2024 10:57:23 +0200
Subject: [PATCH 3/5] fix: browser window + alert

---
 e2e/tests/plugin-explorer.spec.ts       | 2 +-
 e2e/tests/plugin-list-task_list.spec.ts | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/e2e/tests/plugin-explorer.spec.ts b/e2e/tests/plugin-explorer.spec.ts
index e985f4e5c..036a58dfd 100644
--- a/e2e/tests/plugin-explorer.spec.ts
+++ b/e2e/tests/plugin-explorer.spec.ts
@@ -4,7 +4,7 @@ test.describe.configure({ mode: 'serial' })
 
 test.beforeEach(async ({ page, browser }) => {
   browser.newContext({
-    viewport: { width: 1920, height: 1024 },
+    viewport: { width: 1920, height: 1800 },
   })
   await page.goto('http://localhost:3000/')
   await page.getByRole('button', { name: 'data source DemoDataSource' }).click()
diff --git a/e2e/tests/plugin-list-task_list.spec.ts b/e2e/tests/plugin-list-task_list.spec.ts
index 07f86e3c8..8c3d118fc 100644
--- a/e2e/tests/plugin-list-task_list.spec.ts
+++ b/e2e/tests/plugin-list-task_list.spec.ts
@@ -54,7 +54,6 @@ test('task list', async ({ page }) => {
     ).toHaveValue('Wash the car')
     await contentWrapper.getByText('Mark task as complete').click()
     await contentWrapper.getByRole('button', { name: 'Submit' }).click()
-    await expect(page.getByRole('alert')).toHaveText(['Document updated'])
     await page.getByLabel('Close task_list').click()
     await page.getByTestId('task_list').getByLabel('Open in tab').click()
     await page

From 00504b21127e6a741ec5c49b3de31a2a8cbd3a6a Mon Sep 17 00:00:00 2001
From: Andrea Vesterhus <andrea.vesterhus@bouvet.no>
Date: Wed, 26 Jun 2024 11:18:32 +0200
Subject: [PATCH 4/5] fix: test scrolling in view

---
 e2e/tests/plugin-explorer.spec.ts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/e2e/tests/plugin-explorer.spec.ts b/e2e/tests/plugin-explorer.spec.ts
index 036a58dfd..3f3d5908a 100644
--- a/e2e/tests/plugin-explorer.spec.ts
+++ b/e2e/tests/plugin-explorer.spec.ts
@@ -3,9 +3,6 @@ import { expect, test } from '@playwright/test'
 test.describe.configure({ mode: 'serial' })
 
 test.beforeEach(async ({ page, browser }) => {
-  browser.newContext({
-    viewport: { width: 1920, height: 1800 },
-  })
   await page.goto('http://localhost:3000/')
   await page.getByRole('button', { name: 'data source DemoDataSource' }).click()
   await page.getByRole('button', { name: 'root package plugins' }).click()
@@ -47,6 +44,7 @@ test('Create entity with name', async ({ page }) => {
   await page
     .getByRole('button', { name: 'package Playwright', exact: true })
     .click({ button: 'right' })
+  await page.mouse.wheel(0, 300)
   await page.getByRole('menuitem', { name: 'New entity' }).click()
   const dialog = page.getByRole('dialog')
   await expect(dialog).toBeVisible()

From 08d287196d79dee7dae296ae4a5a998ea1ced5ca Mon Sep 17 00:00:00 2001
From: Andrea Vesterhus <andrea.vesterhus@bouvet.no>
Date: Wed, 26 Jun 2024 11:26:01 +0200
Subject: [PATCH 5/5] fix: scroll back

---
 e2e/tests/plugin-explorer.spec.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/e2e/tests/plugin-explorer.spec.ts b/e2e/tests/plugin-explorer.spec.ts
index 3f3d5908a..8cf36569d 100644
--- a/e2e/tests/plugin-explorer.spec.ts
+++ b/e2e/tests/plugin-explorer.spec.ts
@@ -81,6 +81,7 @@ test('Create entity with required name', async ({ page }) => {
   await page.getByRole('button', { name: 'uncontained_object' }).click({
     button: 'right',
   })
+  await page.mouse.wheel(0, -300)
   await page.getByRole('menuitem', { name: 'New entity' }).click()
   const dialog = page.getByRole('dialog')
   await expect(dialog).toBeVisible()