From 2c94d3998d836c4d8cdbaadd3bfcb69687824344 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Eide?= Date: Wed, 23 Oct 2024 12:39:04 +0200 Subject: [PATCH] Combine dicts instead of mutating user environment variables --- src/ert/config/ert_config.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ert/config/ert_config.py b/src/ert/config/ert_config.py index 47b3c91fc69..cae81517d3b 100644 --- a/src/ert/config/ert_config.py +++ b/src/ert/config/ert_config.py @@ -651,13 +651,13 @@ def forward_model_data_to_json( itr: int = 0, context_env: Optional[Dict[str, str]] = None, ): - if context_env is not None: - self.env_vars.update(context_env) + if context_env is None: + context_env = {} return self._create_forward_model_json( context=self.substitution_list, forward_model_steps=self.forward_model_steps, user_config_file=self.user_config_file, - env_vars=self.env_vars, + env_vars={**self.env_vars, **context_env}, run_id=run_id, iens=iens, itr=itr,