Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler is flaky, "Too many realizations failed" #7522

Closed
jonathan-eq opened this issue Mar 25, 2024 · 5 comments · Fixed by #7562
Closed

Scheduler is flaky, "Too many realizations failed" #7522

jonathan-eq opened this issue Mar 25, 2024 · 5 comments · Fixed by #7562
Assignees

Comments

@jonathan-eq
Copy link
Contributor

Describe the bug
The test tests/integration_tests/analysis/test_es_update.py::test_update_multiple_param is very flaky, atleast using scheduler.

FAILED tests/integration_tests/analysis/test_es_update.py::test_update_multiple_param[using_scheduler] - ert.cli.main.ErtCliError: Too many realizations have failed! Number of successful realizations: 9, expected minimal number of successful realizations: 10

(https://github.com/equinor/ert/actions/runs/8420486419/job/23055374718?pr=7521)

Expected behaviour
Not flaky.

Environment

  • OS: Mostly macos-latest
  • ERT/Komodo release: main
  • Python version: Mostly (if not only) 3.12
  • Remote/HPC execution involved: Github Actions runner

Additional context
Add any other context about the problem here.

@jonathan-eq
Copy link
Contributor Author

It is currently marked as skipped due to it blocking PRs.

@eivindjahren
Copy link
Contributor

Seems like this is not isolated to any one test. Realizations are intermittently marked as failing on local queue: https://github.com/equinor/ert/actions/runs/8524062765/job/23347923749

@jonathan-eq jonathan-eq added the bug label Apr 3, 2024
@berland berland changed the title Flaky integration test analysis/test_es_update.py::test_update_multiple_param Scheduler is flaky, "Too many realizations failed" Apr 4, 2024
@berland
Copy link
Contributor

berland commented Apr 4, 2024

This seems to occur at multiple places with the same symptom, "Too many realizations failed", not only when running pytest but also integration tests with poly_example.

When looking at the jobqueue log and in poly_out, all realizations are fine. This points to the problem being the sending of events after all realizations are finished to the ensemble evaluator.

@xjules
Copy link
Contributor

xjules commented Apr 4, 2024

Another one:

FAILED tests/integration_tests/test_cli.py::test_that_the_model_warns_when_active_realizations_less_min_realizations[using_scheduler] - ert.cli.main.ErtCliError: Too many realizations have failed! Number of successful realizations: 4, expected minimal number of successful realizations: 5

https://github.com/equinor/ert/actions/runs/8553593756/job/23437210565?pr=7561

@xjules xjules self-assigned this Apr 4, 2024
@xjules xjules moved this to In Progress in SCOUT Apr 4, 2024
@xjules xjules moved this from In Progress to Ready for Review in SCOUT Apr 5, 2024
@jonathan-eq jonathan-eq moved this from Ready for Review to Reviewed in SCOUT Apr 5, 2024
@berland
Copy link
Contributor

berland commented Apr 5, 2024

See #7569 for a test potentially catching the same issue.

@xjules xjules moved this from Reviewed to In Progress in SCOUT Apr 5, 2024
@xjules xjules moved this from In Progress to Ready for Review in SCOUT Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in SCOUT Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants