Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for granular access based on Installation Controller #1212

Closed
Tracked by #1154
UsamaEquinorAFK opened this issue Nov 22, 2023 · 1 comment · Fixed by #1253
Closed
Tracked by #1154

Test for granular access based on Installation Controller #1212

UsamaEquinorAFK opened this issue Nov 22, 2023 · 1 comment · Fixed by #1253
Assignees
@andchiind
Labels
backend Backend related functionality feature New feature or request

Comments

@UsamaEquinorAFK
Copy link
Contributor

Describe the test you would like to make

Write a test, which matches the Role based granular access (Role.Installation.User or Admin) with the current chosen installation (the installation sent as a part of query). Hence we should not be able to make a query for an installation which one does not have access for.

How will this change existing functionality?

Additions to this model inside controller \flotilla\backend\api\Controllers\Models\Role.cs

How will this improvement affect the current Threat Model?

Users/ Admins can only perform operations on installations assigned to them
@UsamaEquinorAFK UsamaEquinorAFK added feature New feature or request backend Backend related functionality labels Nov 22, 2023
@UsamaEquinorAFK UsamaEquinorAFK changed the title Test for granular access based on Installation Code Test for granular access based on Installation Controller Nov 22, 2023
@tsundvoll tsundvoll mentioned this issue Nov 22, 2023
Closed
2 tasks
@andchiind
Copy link
Contributor

Dependent on #1211
and arguably also #1202

@andchiind andchiind self-assigned this Dec 11, 2023
@andchiind andchiind mentioned this issue Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andchiind andchiind

Labels
backend Backend related functionality feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Utilise non-admin roles in tests andchiind/flotilla
2 participants
@andchiind @UsamaEquinorAFK