Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests should return 400 if they fail to schedule a mission #1226

Closed
andchiind opened this issue Nov 28, 2023 · 3 comments
Closed

Requests should return 400 if they fail to schedule a mission #1226

andchiind opened this issue Nov 28, 2023 · 3 comments
Labels
backend Backend related functionality bug Something isn't working

Comments

@andchiind
Copy link
Contributor

Describe the bug
When scheduling a custom mission, if we attempt to schedule it in an area the requested robot is not in, it will state that it failed and instead return a 200 code, with a mission run with a null area.

To Reproduce
POST a custom mission in an area with no robots

Expected behavior
This should return a 400 error stating that there are no robots in the area (even if there are robots there and they just don't have access, since we would otherwise be giving them information they do not have access to ie. that there are robots there)

Screenshots
If applicable, add screenshots to help explain your problem.

@andchiind andchiind added bug Something isn't working backend Backend related functionality labels Nov 28, 2023
@oysand
Copy link
Contributor

oysand commented Dec 11, 2023

Should be handed as part of #950

@andchiind
Copy link
Contributor Author

@oysand Has this been handled?

@andchiind andchiind assigned andchiind and unassigned andchiind Jan 4, 2024
@Afonso-2403 Afonso-2403 removed their assignment Feb 28, 2024
@Eddasol
Copy link
Contributor

Eddasol commented Apr 18, 2024

Tried to reproduce but doesn't occur as described anymore. Will close

@Eddasol Eddasol closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants