Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue is wrong after pressing "Queue all missions" #1227

Open
Eddasol opened this issue Nov 28, 2023 · 4 comments
Open

Queue is wrong after pressing "Queue all missions" #1227

Eddasol opened this issue Nov 28, 2023 · 4 comments
Labels
bug Something isn't working frontend Frontend related functionality stale This issue or pull request already exists

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Nov 28, 2023

Describe the bug
After queuing all missions for a deck the queue is in the order the missions completed loading and not in the order it will run. Reloading will show the correct order.

To Reproduce
Recommend starting a mission and pausing it before doing the following steps such that the missions don't start instantly

  1. Queue all mission on a deck with several missions
  2. Wait for all the missions to load, note the order
  3. Reload the page, note the order

Expected behavior
The queue order should match the order the missions will run in

Screenshots
After queuing all missions
changingQueue

After reloading
changingQueue2

@Eddasol Eddasol added bug Something isn't working frontend Frontend related functionality labels Nov 28, 2023
@andchiind
Copy link
Contributor

The reason for this is that each mission does not know its ordering. The ordering currently is arbitrary on the backend. So when the signalR message is sent we don't know how it has been ordered on the backend. We might need to consider implementing a consistent ordering, eg. having a single increment for each mission run that is globally unique

@aeshub
Copy link
Contributor

aeshub commented Feb 7, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Feb 7, 2024
@Eddasol Eddasol removed the stale This issue or pull request already exists label Mar 21, 2024
@aeshub
Copy link
Contributor

aeshub commented May 21, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label May 21, 2024
@Christdej Christdej removed the stale This issue or pull request already exists label Aug 5, 2024
@aeshub
Copy link
Contributor

aeshub commented Oct 9, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend related functionality stale This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants