Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission queue should be sorted by closest deadline #1228

Open
Eddasol opened this issue Nov 28, 2023 · 5 comments
Open

Mission queue should be sorted by closest deadline #1228

Eddasol opened this issue Nov 28, 2023 · 5 comments
Labels
improvement Improvement to existing functionality stale This issue or pull request already exists

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Nov 28, 2023

Describe the improvement you would like to see
Missions on a deck is sorted by deadline and when scheduling all missions on a deck the queue should get the same order such that missions with a short deadline ends up first in the queue.

Missions on the deck, ordered by deadline
image

Mission Queue after queuing all missions
image

How will this change existing functionality?
Missions with short deadline will run first

How will this improvement affect the current Threat Model?
N/A

@Eddasol Eddasol added the improvement Improvement to existing functionality label Nov 28, 2023
@andchiind
Copy link
Contributor

This could be solved by having global ordering, where each mission is assigned a unique incrementing number. This way we could allow the user to reorder the queue in any way they want, while also having it be predictable for a user. This would also prevent starvation where missions without a deadline are always put to the end of the queue.

@andchiind
Copy link
Contributor

It is hard to actually achieve the same ordering on the frontend and backend unless we purposefully slow down the frontend. This would also still not guarantee the same ordering. See the above comment for a potential fix.

@andchiind
Copy link
Contributor

Alternatively we'll need to ensure we use the same sorting of mission runs on the frontend and backend in respect to deadlines, but if two missions have the same timings, or if neither has an inspection frequency, then there would still be inconsistencies.

@aeshub
Copy link
Contributor

aeshub commented Jun 1, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jun 1, 2024
@Christdej Christdej removed the stale This issue or pull request already exists label Aug 5, 2024
@aeshub
Copy link
Contributor

aeshub commented Oct 9, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality stale This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants