Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name from "Enabled" to "isarConnected" #1249

Closed
prasm313 opened this issue Dec 11, 2023 · 2 comments · Fixed by #1489
Closed

Change name from "Enabled" to "isarConnected" #1249

prasm313 opened this issue Dec 11, 2023 · 2 comments · Fixed by #1489
Assignees

Comments

@prasm313
Copy link
Contributor

prasm313 commented Dec 11, 2023

Describe the improvement you would like to see
Change the name of the robot parameter "Enabled" to "isarConnected".

How will this change existing functionality?
It will be more clear what this parameter actually is telling us. We have other parameters that this parameter can be confused with ("Available", "Offline", "Idle").

@andchiind
Copy link
Contributor

This could be a good change on the backend, but I think it's still best to keep it as Enabled in the frontend models since the frontend should ideally not need to care about the existence of Isar

@aeshub
Copy link
Contributor

aeshub commented Feb 13, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Feb 13, 2024
@Eddasol Eddasol removed the stale This issue or pull request already exists label Mar 22, 2024
@Eddasol Eddasol linked a pull request Mar 22, 2024 that will close this issue
@Eddasol Eddasol self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants