-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a SecretService for backend #1306
Comments
Great name for a service |
I feel that the threat model could be affected, if we're not careful |
I agree, as it says it's a proposed improvement. If there is something specific which anyone thinks should be considered we can look over that but as I understand we can't fetch secrets if we haven't completed az login step so we should be safe. |
Check if it is possible to do well through the appsettings |
This issue has automatically been marked as stale as there has been no activity for 60 days. |
Appsettings is good enough |
Describe the improvement you would like to see
Add a new service for retrieving secrets from keyvault to reduce redundant code.
How will this change existing functionality?
Will have one place where all secret fetching is handled, and less code in different services.
How will this improvement affect the current Threat Model?
N/A - Feel free to add anything here if I missed something.
The text was updated successfully, but these errors were encountered: