Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a SecretService for backend #1306

Closed
UsamaEquinorAFK opened this issue Jan 4, 2024 · 6 comments
Closed

Make a SecretService for backend #1306

UsamaEquinorAFK opened this issue Jan 4, 2024 · 6 comments
Labels
improvement Improvement to existing functionality question Further information is requested

Comments

@UsamaEquinorAFK
Copy link
Contributor

UsamaEquinorAFK commented Jan 4, 2024

Describe the improvement you would like to see
Add a new service for retrieving secrets from keyvault to reduce redundant code.

How will this change existing functionality?
Will have one place where all secret fetching is handled, and less code in different services.

How will this improvement affect the current Threat Model?
N/A - Feel free to add anything here if I missed something.

@UsamaEquinorAFK UsamaEquinorAFK added the improvement Improvement to existing functionality label Jan 4, 2024
@tsundvoll
Copy link
Contributor

Great name for a service

@andchiind
Copy link
Contributor

I feel that the threat model could be affected, if we're not careful

@UsamaEquinorAFK
Copy link
Contributor Author

UsamaEquinorAFK commented Jan 4, 2024

I agree, as it says it's a proposed improvement. If there is something specific which anyone thinks should be considered we can look over that but as I understand we can't fetch secrets if we haven't completed az login step so we should be safe.

@UsamaEquinorAFK UsamaEquinorAFK added the question Further information is requested label Jan 8, 2024
@oysand
Copy link
Contributor

oysand commented Jan 8, 2024

Check if it is possible to do well through the appsettings

@aeshub
Copy link
Contributor

aeshub commented May 4, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label May 4, 2024
@Christdej Christdej removed the stale This issue or pull request already exists label Aug 5, 2024
@Christdej
Copy link
Contributor

Appsettings is good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants