Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robot has status offline if the broker restarts #1359

Closed
prasm313 opened this issue Jan 26, 2024 · 6 comments · Fixed by #1781
Closed

Robot has status offline if the broker restarts #1359

prasm313 opened this issue Jan 26, 2024 · 6 comments · Fixed by #1781
Assignees
@andchiind
Labels
backend Backend related functionality bug Something isn't working improvement Improvement to existing functionality

Comments

@prasm313
Copy link
Contributor

Describe the improvement you would like to see
If the broker goes down and is restarted, the robots has "offline" as their status. If the robot is available or busy when the broker restarts this should be visible in Flotilla.

How will this change existing functionality?
Robots will not be stuck in offline. Will not be necessary to manually set status as Available through swagger. The users would not need to contact us if the broker has restarted.

How will this improvement affect the current Threat Model?
N/A
@prasm313 prasm313 added bug Something isn't working backend Backend related functionality improvement Improvement to existing functionality labels Jan 26, 2024
@oysand oysand mentioned this issue Feb 5, 2024
Closed
@Afonso-2403
Copy link
Contributor

Could updating the robot status in OnIsarRobotHeartbeat if the robot is not enabled solve this problem?
The only thing is that as of now the robot status is not contained in the heartbeat.

@oysand oysand mentioned this issue Mar 22, 2024
Closed
8 tasks
@prasm313 prasm313 removed their assignment Apr 15, 2024
@tsundvoll
Copy link
Contributor

Blocked waiting on improved communication between ISAR and Flotilla. This includes some new states in ISAR. It also means we can rely on one of the messages instead of the combined status message.

@aeshub
Copy link
Contributor

aeshub commented Jul 3, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jul 3, 2024
@Christdej Christdej removed the stale This issue or pull request already exists label Aug 5, 2024
@aeshub
Copy link
Contributor

aeshub commented Oct 7, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Oct 7, 2024
@tsundvoll
Copy link
Contributor

Ready to be retested

@tsundvoll tsundvoll removed the stale This issue or pull request already exists label Oct 7, 2024
@tsundvoll
Copy link
Contributor

Still an issue. Consider using the "heartbeat" to check regularly for a change in status.

@andchiind andchiind self-assigned this Oct 29, 2024
@andchiind andchiind mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andchiind andchiind

Labels
backend Backend related functionality bug Something isn't working improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flotilla not reporting connection issues after broker goes down andchiind/flotilla
6 participants
@aeshub @andchiind @tsundvoll @Christdej @Afonso-2403 @prasm313