Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missions to the queue before localization mission is finished #1463

Closed
mrica-equinor opened this issue Mar 11, 2024 · 3 comments · Fixed by #1718
Closed

Add missions to the queue before localization mission is finished #1463

mrica-equinor opened this issue Mar 11, 2024 · 3 comments · Fixed by #1718
Assignees
Labels
backend Backend related functionality bug Something isn't working improvement Improvement to existing functionality

Comments

@mrica-equinor
Copy link
Contributor

Describe the bug
When scheduling additional missions to the queue while there is an ongoing localization mission, the mission is not added. This is due to the fact that for the mission to be added to the queue, it has to be in the same deck as the robot is localized and since the localization mission hans't finished, the robot doesn't have a deck yet.

Suggested solution is to have a check when adding a new mission to the queue for ongoing localization missions and if the mission added is in the same deck as the ongoing localization mission, then it should be added in the queue.

To Reproduce
Add mission to the queue before the localization mission updated the robot current area.

Expected behavior
As long as the mission to be added is in the same deck as the ongoing localization mission or in the same deck as the robot current area, it should be added to the queue.

Screenshots
If applicable, add screenshots to help explain your problem.

@mrica-equinor mrica-equinor added the bug Something isn't working label Mar 11, 2024
@mrica-equinor mrica-equinor changed the title Adding missions to the queue before localization missions is finished Add missions to the queue before localization missions is finished Mar 11, 2024
@mrica-equinor mrica-equinor added the backend Backend related functionality label Mar 11, 2024
@tsundvoll tsundvoll added the improvement Improvement to existing functionality label Mar 11, 2024
@andchiind
Copy link
Contributor

Alternate solution could be to set the deck of the robot as soon as we queue the localisation mission, and instead we can perform cleanup of the queue if the localisation mission fails. We anyways will not start other missions until the localisation mission finishes.

@aeshub
Copy link
Contributor

aeshub commented May 25, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label May 25, 2024
@aeshub aeshub removed the stale This issue or pull request already exists label Jul 18, 2024
@mrica-equinor mrica-equinor changed the title Add missions to the queue before localization missions is finished Add missions to the queue before localization mission is finished Aug 7, 2024
@mrica-equinor
Copy link
Contributor Author

This issue has changed. Currently it is possible to add the mission to the queue but the user still sees a popup confirmation that the robot is in the default localization pose for as long as the robot current area is null.

On placebot this isn't an issue because the first task of the mission completes fast enough that the current area will be set almost immediately. But with a real robot, the first task might take several minutes.

This issue will be therefore handled by changing the localization confirmation dialog to check if there are ongoing localization missions intead of relying on the robot having current area set to null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality bug Something isn't working improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants