Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve enum MissionRunPriority #1472

Closed
mrica-equinor opened this issue Mar 18, 2024 · 2 comments
Closed

Improve enum MissionRunPriority #1472

mrica-equinor opened this issue Mar 18, 2024 · 2 comments
Labels
backend Backend related functionality bug Something isn't working stale This issue or pull request already exists

Comments

@mrica-equinor
Copy link
Contributor

mrica-equinor commented Mar 18, 2024

Describe the improvement you would like to see
Currently the enum MissionRunPriority is used as a way to both filter which missions in the queue should be prioritized and the kind of mission they are. Instead, the enum should be changed to MissionRunType since this is a more accurate definition for the missions.

Mission types should be:

How will this change existing functionality?
This will make it easier to avoid scenarios where the return to home mission is triggered, for example. We can check that if the mission run was a move robot arm (which is a mission with no tasks other than move the robot arm), the return to home mission shouldn't be triggered.

How will this improvement affect the current Threat Model?
Leave blank for maintainers to fill out if you are uncertain about this.

@mrica-equinor mrica-equinor added improvement Improvement to existing functionality bug Something isn't working backend Backend related functionality and removed improvement Improvement to existing functionality labels Mar 18, 2024
@aeshub
Copy link
Contributor

aeshub commented May 18, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label May 18, 2024
@mrica-equinor
Copy link
Contributor Author

Close this since it has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality bug Something isn't working stale This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants