Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetRobotToIsarDisconnected does more than the name indicates #1493

Closed
Tracked by #1483
Eddasol opened this issue Mar 22, 2024 · 0 comments · Fixed by #1500
Closed
Tracked by #1483

SetRobotToIsarDisconnected does more than the name indicates #1493

Eddasol opened this issue Mar 22, 2024 · 0 comments · Fixed by #1500
Assignees
@andchiind
Labels
backend Backend related functionality good first issue Good for newcomers improvement Improvement to existing functionality

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Mar 22, 2024

Describe the improvement you would like to see
The function SetRobotToIsarDisconnected in RobotService.cs does more than the name indicates. The function should be rewritten/split.

#1489 (comment)

How will this change existing functionality?
More readable code

How will this improvement affect the current Threat Model?
@Eddasol Eddasol added backend Backend related functionality improvement Improvement to existing functionality labels Mar 22, 2024
@Eddasol Eddasol mentioned this issue Mar 22, 2024
Merged
@Eddasol Eddasol added the good first issue Good for newcomers label Mar 22, 2024
@Eddasol Eddasol mentioned this issue Mar 22, 2024
Closed
8 tasks
@andchiind andchiind self-assigned this Mar 27, 2024
@andchiind andchiind mentioned this issue Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andchiind andchiind

Labels
backend Backend related functionality good first issue Good for newcomers improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor set robot to unavailable function andchiind/flotilla
2 participants
@andchiind @Eddasol