Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predefined missions tab sometimes show missions from other installations #1506

Closed
Eddasol opened this issue Apr 2, 2024 · 1 comment · Fixed by #1694
Closed

Predefined missions tab sometimes show missions from other installations #1506

Eddasol opened this issue Apr 2, 2024 · 1 comment · Fixed by #1694
Assignees
Labels
bug Something isn't working frontend Frontend related functionality good first issue Good for newcomers

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Apr 2, 2024

Describe the bug
If a mission definition is created it will show in predefined missions tab, regardless of which installation the user has selected.

To Reproduce

  1. Run new missions on a plant such that mission definitions are created
  2. Change installation and select predefined missions tab. The missions definitions will appear once they are created. Reload and they will disappear again.

Alternatively:

  1. Have two open browsers/tabs with flotilla open at different installations.
  2. Run new missions on one of the plants such that a mission definition is created.
  3. Monitor mission predefined missions tab in the other browser/tab and note the new mission definitions.

This is most likely caused by there being no installation filter used for deciding if a new missionDefinition from signalR should be included in the context.

Expected behavior
Mission definitions should only be shown for the relevant installation

Screenshots

@Eddasol Eddasol added bug Something isn't working frontend Frontend related functionality good first issue Good for newcomers labels Apr 2, 2024
@oysand oysand added this to the Ready for users milestone Apr 28, 2024
@aeshub
Copy link
Contributor

aeshub commented Jul 2, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jul 2, 2024
@betaniat betaniat removed their assignment Jul 26, 2024
@aeshub aeshub removed the stale This issue or pull request already exists label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend related functionality good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants