Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement alert feature #1560

Closed
prasm313 opened this issue Apr 17, 2024 · 6 comments
Closed

Implement alert feature #1560

prasm313 opened this issue Apr 17, 2024 · 6 comments
Assignees
@haakonsf
Labels
feature New feature or request frontend Frontend related functionality
Milestone
Ready for users

Comments

@prasm313
Copy link
Contributor

prasm313 commented Apr 17, 2024 •
edited
Loading

Describe the new feature you would like to see
Implement the notification/alert feature so that the users have an overview of the status of the missions and robots. Some of the frontend work is already done in this closed, non-merged PR #1645.

Describe the solution you'd like
Figma sketch:

Image

How will this feature affect the current Threat Model?
N/A
@prasm313 prasm313 added feature New feature or request frontend Frontend related functionality labels Apr 17, 2024
@prasm313 prasm313 changed the title Implement notification feature Implement notification/alert feature Apr 17, 2024
@anetteu
Copy link
Member

anetteu commented Apr 17, 2024 •
edited
Loading

Consider #1087 when implementing this. Every required action by the user (pressurizing and charging) must be clearly communicated

@anetteu
Copy link
Member

anetteu commented Apr 17, 2024

Suggest to add button to the battery and pressure warnings: Stop missions and drive home.

@oysand oysand added this to the Ready for users milestone Apr 28, 2024
@prasm313 prasm313 changed the title Implement notification/alert feature Implement alert feature May 6, 2024
@prasm313 prasm313 mentioned this issue May 15, 2024
Closed
22 tasks
@prasm313
Copy link
Contributor Author

prasm313 commented Jun 6, 2024

If the alert is regarding a robot, the user should be sent to the robot page when clicking the alert. Clicking alerts related to missions should send the user to missionRun page.

@prasm313 prasm313 self-assigned this Jun 20, 2024
@prasm313
Copy link
Contributor Author

The work has started in PR #1645.

@prasm313 prasm313 removed their assignment Jun 25, 2024
@haakonsf haakonsf self-assigned this Jul 31, 2024
@haakonsf haakonsf mentioned this issue Aug 20, 2024
Merged
@haakonsf
Copy link
Contributor

Frontend display implemented with no functional change to alert generation or banner alerts. See comment in #1592 for more details.

@tsundvoll
Copy link
Contributor

tsundvoll commented Sep 2, 2024 •
edited
Loading

Considered done. Create new issue if adjustments are wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haakonsf haakonsf

Labels
feature New feature or request frontend Frontend related functionality
Projects
None yet
Milestone
Ready for users
Development

No branches or pull requests
5 participants
@anetteu @oysand @tsundvoll @haakonsf @prasm313