Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow and line break style on robot button cards #1698

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix overflow and line break style on robot button cards #1698

merged 1 commit into from
Jul 30, 2024

Conversation

haakonsf
Copy link
Contributor

@haakonsf haakonsf commented Jul 30, 2024 •
edited
Loading

Closes #1695 and #1696

@haakonsf haakonsf linked an issue Jul 30, 2024 that may be closed by this pull request
Content on robot card overflows #1696
Closed
@haakonsf haakonsf force-pushed the Fix-robot-button-cards branch 2 times, most recently from 6b3e5de to 60dd2ff Compare July 30, 2024 10:18
@haakonsf haakonsf added the frontend Frontend related functionality label Jul 30, 2024
@Eddasol
Copy link
Contributor

Eddasol commented Jul 30, 2024

Commit message is a bit long. Suggest something like "Fix overflow and line break on robot status cards"

Eddasol
Eddasol approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rewrite commit message before merging but otherwise good :)

@haakonsf haakonsf force-pushed the Fix-robot-button-cards branch from 60dd2ff to 162a75b Compare July 30, 2024 12:56
@haakonsf haakonsf force-pushed the Fix-robot-button-cards branch from 162a75b to 3e0b863 Compare July 30, 2024 12:58
@haakonsf haakonsf merged commit 59834f6 into equinor:main Jul 30, 2024
10 checks passed
@haakonsf haakonsf deleted the Fix-robot-button-cards branch July 30, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol approved these changes

Assignees

@haakonsf haakonsf

Labels
frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content on robot card overflows Status symbol on robot card doesn't center
2 participants
@haakonsf @Eddasol