Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All external mission loading put inside mission loader #1708

Merged
merged 1 commit into from
Aug 29, 2024
Merged

All external mission loading put inside mission loader #1708

merged 1 commit into from
Aug 29, 2024

Conversation

Christdej
Copy link
Contributor

No description provided.

@Christdej Christdej self-assigned this Aug 6, 2024
@Christdej Christdej added the breaking-change A breaking change which introduces changes to the public APIs label Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Christdej Christdej force-pushed the configservice branch 9 times, most recently from 3e5f325 to 0d28610 Compare August 12, 2024 11:30
@Christdej Christdej marked this pull request as ready for review August 12, 2024 12:07
@Christdej Christdej added backend Backend related functionality frontend Frontend related functionality labels Aug 13, 2024
@Christdej Christdej force-pushed the configservice branch 7 times, most recently from 3f7662b to 4a28abc Compare August 15, 2024 10:55
@Christdej Christdej force-pushed the configservice branch 2 times, most recently from 605358c to eb85cb5 Compare August 20, 2024 06:01
andchiind
andchiind reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. Seems to work well when testing it

backend/api/Configurations/CustomServiceConfigurations.cs Outdated Show resolved Hide resolved
backend/api/Services/MissionLoaders/EchoMissionResponse.cs Show resolved Hide resolved
backend/api/Services/MissionLoaders/MissionLoaderInterface.cs Outdated Show resolved Hide resolved
frontend/best_practises.md Show resolved Hide resolved
frontend/best_practises.md Show resolved Hide resolved
backend/api.test/Database/Models.cs Show resolved Hide resolved
@Christdej Christdej force-pushed the configservice branch 2 times, most recently from 9c64812 to d2798bb Compare August 29, 2024 07:52
@Christdej Christdej requested a review from andchiind August 29, 2024 07:57
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Aug 29, 2024
@Christdej
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@Christdej Christdej merged commit 54ba48c into equinor:main Aug 29, 2024
12 checks passed
@Christdej Christdej deleted the configservice branch August 29, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@Christdej Christdej

Labels
backend Backend related functionality breaking-change A breaking change which introduces changes to the public APIs database-change Will require migration frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christdej @andchiind